jungshik@google.com 2008-08-28T04:32:54.133330Z Add region-specific suggest URLs for Yahoo_xx search engines where suggest service is available. Add utf8 output flag to Naver (#1 engine in Korea) so that JSON comes back in UTF-8. meta.ua (Ukraine search engine) was changed similarly. Change the url for Yahoo_sg to sg.yahoo.com (from tw.yahoo.com) and that for Yahoo_nz to nz.yahoo.com (from sg.yahoo.com) Disable the suggestion service for Daum because it returns the result in EUC-KR and currently we assume it's in UTF-8 (issue 1293145). Also disable Yahoo_xx's that do not offer suggestion/ac services. We can do some mappings (e.g. at, ch => de, qc => ca or fr, hk => tw or en and nl,no,dk, fi => en, the rational for the last being that English proficiency of general public in those countries is rather good.), but disable it for now. BUG=1342120 TEST=Install various language versions of Chrome and set the default search engines to a regional Yahoo variant and see if suggest works in the omnibar. Install Korean Chrome and set the default search engine to Naver and see if suggesst works. jabdelmalek@google.com 2008-08-28T05:31:41.714647Z Fix problem of safebrowsing database removing an add for a hostname when it got a sub for some prefixes. BUG=1315628 rahulk@google.com 2008-08-28T15:58:53.189900Z Use distribution specific branding for binaries version stamp. BUG=1296800 sky@google.com 2008-08-28T16:10:30.239186Z Fixes regression where we were no longer deleting TabContents when navigating to a new TabContents. BUG=1349274 TEST=none finnur@google.com 2008-08-28T16:31:57.599662Z Adding a test to catch regressions where the Find box moves when you open and close a tab. Test is disabled until we fix the bug. Also made the error message for when tests fails because crash_service isn't running a bit explicit (unrelated to the rest of this change). BUG=1343052 mmentovai@google.com 2008-08-28T16:44:16.497658Z Set svn:eol-style = LF and normalize newlines as on other files rahulk@google.com 2008-08-28T16:50:25.414486Z fix typo finnur@google.com 2008-08-28T17:14:28.642387Z No code change, just changing a comment (a nit from my previous review). This fixes that. TBR=sky pkasting@google.com 2008-08-28T17:20:26.580799Z Split the AutocompletePopup into model and view classes, step 1. The just adds "Model" and "View" to the end of the current classname, leaves everything in the same files, and doesn't really change or remove any functionality, creation order, ownership semantics, etc. In other words, it's basically just moving some code around to get things split into two classes, and the harder work comes later. Also removes/trims some overly long comments, fixes a couple comment errors I noticed, and trims one or two bits of logic to be shorter. What really needs review the most is the high-level decisions about how to split data and functionality between the two classes. BUG=1343512 mbelshe@google.com 2008-08-28T17:59:38.189633Z Enable logging on memory tests for debugging. mmoss@google.com 2008-08-28T18:26:42.087678Z This call is incorrect because calling it here allows any subframe to update "is_loading_", which represents state on the main frame, and thus should only be updated to reflect changes to that frame (as ProgressTracker is careful to do by testing "m_originatingProgressFrame"). It's also redundant because it is already triggered through the ProgressTracker, even when there is a ProvisionalLoad error. This fixes issues where the favicon for a page was not being loaded because of errors in subframes. BUG=1186854 erg@google.com 2008-08-28T18:36:37.463275Z The GetWindowRect must return the rect of the container HWND; not the actual window rect. The usage of GetWindowRect in the ChromeClientImpl::windowRect() function is erroneous, and my modification of GetWindowRect to return the HWND's root ancestor rect broke drop down combo boxes and other embeded controls. So instead, add a GetRootWindowRect which gets the root anncestor of the HWND's rect and use it in ChromeClientImpl::windowRect(). BUG=1344367,1186573,1334505 finnur@google.com 2008-08-28T20:12:36.940342Z Fix for the redness in the interactive test. We were using GetActiveWindow to get the Browser window, which internally uses ::GetForegroundWindow(). This means that when other application windows are on top we fail to get the Browser window. By switching to GetLastActiveWindow() we avoid that. sky@google.com 2008-08-28T20:43:50.902328Z Attempt at fixing crash in TaskManager. I'm skeptical this is it, but it's worth a shot. BUG=1345092 TEST=none darin@google.com 2008-08-28T20:50:12.755546Z Simplify OneShotTimer and RepeatingTimer. Fix up all consumers. Major changes: OneShotTimer and RepeatingTimer become template classes that no longer require a Task or a Timer object. They just use PostDelayedTask. Under the hood that still uses a Timer object. The API is much simpler for consumers as they now no longer need to worry about allocating a Task or managing the lifetime of the object pointer held by the Task. I added some new unit tests to timer_unittest.cc to cover the API. I preserved the old TimerManager / Timer API for now, but I plan to soon kill it. R=brettw BUG=1346553 rahulk@google.com 2008-08-28T21:39:31.297443Z Fix tests that break with Chromium build. BUG=1296800 brettw@google.com 2008-08-28T22:10:17.870414Z Make a step on refactoring navigation. The eventual plan is to have the NavigationController create and commit the new NavigationEntries (currently WebContents does a bunch of the details of this which is hard to understand and not easily testable). This tries to consolidate the logic that I want to move to the NavigationController without actually moving it there yet. I removed all of the "PreCommit" functions in WebContents, since when the NavigationController does all of the committing, there won't be a phase where the NavigationEntry exists but isn't committed. Most of the logic could be moved to the PostCommit functions without any problem, which is an indication that the current design was busted anyway. I had to precompute some data and pass it to the *PostCommit function to work around some of the components that required old data. I had to change InfoBars around since it relied on having both the committed and uncommitted entries, but I think the new design is much better anyway. BUG=1343593,1343146 brettw@google.com 2008-08-28T22:11:07.232797Z Forgotten unit test chanes. finnur@google.com 2008-08-28T22:11:13.177133Z We should not EXPECT to get a browser object or a window object, we should ASSERT that we got it (which ends the test on NULL pointers). Otherwise we continue on and crash when we try to use these pointers, such as when passing it into GetBrowserForWindow. sky@google.com 2008-08-28T22:33:36.775227Z Fixes crash in ClearBrowsingDataView that can only occur during the automated tests. If the window is closed while a removal is in progress the BrowsingDataRemover would be left with a reference to a deleted object. This can only happen during automated testing as while clearing is in progress we don't allow the user to close the dialog. BUG=1138705 TEST=covered by automated test bot deanm@google.com 2008-08-29T08:58:27.423272Z We don't need to support win2k, so we can always use rand_s. We can also use this for the non-secure case, which simplifies things since we shouldn't need to worry about threading anymore. sgk@google.com 2008-08-29T09:02:49.591999Z Remove navigation_performance_viewer.{cc,h} from the SCons build, and for real. TBR: brettw sgk@google.com 2008-08-29T10:16:43.770273Z SCons build: Generate the chromium_strings* and google_chrome_string* resource and .h files from their .grd files. TBR: rahulk sgjesse@google.com 2008-08-29T11:07:40.769286Z Made changes to the JavaScript debugger in preparing for an upcoming change in V8 where the implicit breaks currently issued when receiving a command while running will be removed. To get in contact with the V8 debugging interface and send messages V8 needs to be in the break state. Getting V8 into the break state will be the responsebility of the debugger using the V8 debugging interface. Changed the messages between the renderer and the debugger. There are now explicit messages for break and detach. Alse renamed the SendToDebugger message to DebugCommand. There is now messages DebugAttach, DebugBreak, DebugCommand and DebugDetach. The message DebugBreak has a force flag to indicate whether the renderer should issue some JavaScript to help the break along or whether it should just schedule a break to happen whenever JavaScript executes. Removed the artificial attach JSON response send by the renderer and replaced that with an on debug attach call to the debugger shell. This call is reouted to the on_attach function in the debugger JavScript code. Changed the debugger to issue break requests whenever a suitable command, e.g. setting a break point, is issued. In this case a flag is used to track whether execution should be automatically resumed after the command have been send to the V8 debugger interface. Changed the handling of the plain break event to not force a break by executing additional JavaScript. Thereby a plain break does not break JavaScript execution until code on the tab beeing debugged is actually executed. Set the command name explicitly on all commands. Removed parseSimpleCommand as it was just used for the the continue command for which an explicit parseContinueCommand has been added. Removed the last_command field from DebugShell as it was not used. Updated the debugger protocol test to reflect the removed attach event. rahulk@google.com 2008-08-29T15:53:51.825306Z Last minute changes for Chromium. rahulk@google.com 2008-08-29T16:10:07.915403Z fix build failure rahulk@google.com 2008-08-29T16:24:24.251214Z Rollback 1529. pamg@google.com 2008-08-29T16:39:54.190050Z Fix disabled debugger project in JSC. TBR=sgjesse BUG=none TEST=none sky@google.com 2008-08-29T18:45:30.969905Z Fixes bug where it was possible for tab to get the wrong title. Came across this in investigating another problem. BUG=1307747 TEST=Create > 3 tabs. In the last one open the html file attached to 1305707. Click on the button. Rapidly drag the first tab in and out of the tab strip and make sure none of the remaining tabs get the wrong title. tc@google.com 2008-08-29T19:18:51.700309Z Update chrome strings. TBR=mal maruel@google.com 2008-08-29T19:21:29.430396Z Fix two tests that expected en-US locale and were failing otherwise. sky@google.com 2008-08-29T19:46:56.879068Z Makes the HistoryContentsProvider query bookmark titles. I nuked a couple of fields that I felt were redundant. I'm pretty sure I got the same logic, but you better stare at this to convince yourself. BUG=1256202 TEST=covered by unit tests sky@google.com 2008-08-29T19:48:58.364688Z Modifies the query parser to provide the position of the match in the title. I'm going to use this in the omnibox. There are a couple of other random spelling errors I came across that are included for your review pleasure. BUG=1256202 TEST=none cpu@google.com 2008-08-29T19:51:06.589171Z Adds a logging level command line switch - Adds --log-level=n with n=0,1,2,3 - Increases the default logging level from INFO to WARNING there is way too much noise there. rahulk@google.com 2008-08-29T19:51:32.901828Z Exe/Dlls dependencies can be different between Chromium/Google Chrome. Add support for distribution specific dependencies in depedency checker. BUG=1296800 maruel@google.com 2008-08-29T20:01:03.682875Z Fix the unit test when run from a MUI-Aware Vista installation and the current UI language is not the same as the installation language. aa@google.com 2008-08-29T20:27:01.788381Z This file should have been removed awhile ago when we upgraded SQLite. Removing now because WebCore will soon need sqlite in the include path and this file will then conflict with std::limits. See also: http://www.sqlite.org/cvstrac/chngview?cn=4091 mbelshe@google.com 2008-08-29T22:44:42.934305Z Make the user data directory configurable from the cmdline for the memory tests. erg@google.com 2008-08-29T23:41:12.810293Z Implement the 11th hour Google Chrome Beta behaviour for constrained popup windwos: - Pull out the favicon - Manually check the current locale; if it's an english one then display the string "Popup Blocked", otherwise use just the popup's title (without the product name suffixed to it). BUG=1085485 ifette@google.com 2008-08-29T23:42:20.575644Z On line 138 of protocol_manager.cc we were converting a std::string to a char*. The string could contain null bytes, which led to data loss and failures in safebrowsing. R=wtc BUG=1352561 rahulk@google.com 2008-08-29T23:57:39.546060Z Do not put version info in patch archive file name. It is not useful as user do not ever get to see this file and it will make the signing of executables process more complex. BUG=1179486 rahulk@google.com 2008-08-29T23:58:10.201330Z Initialize Breakpad for Chromium as well. BU=1296800 maruel@google.com 2008-08-30T00:04:34.125311Z Fix the order when setting the last error code. On XP, it was reset by the GetProcAddress() call. TBR=nsylvain erg@google.com 2008-08-30T00:06:47.614200Z Disable the constrained popup window title checking test. TBR=sky aa@google.com 2008-08-30T01:36:02.781718Z Move SQLite from src/chrome/third_party to src/third_party since it will be shared with WebCore and Gears in the future. pamg@google.com 2008-08-30T18:43:14.900795Z Switch to building Chromium rather than Google Chrome by default. The official builder will need the CHROMIUM_BUILD environment variable set to "_google_chrome". Same as Rietveld issue 2943, approved by nsylvain and rahulk, but in the writeable repository rather than the read-only one. BUG=1296800 TEST=covered by buildbots pamg@google.com 2008-08-30T18:52:07.327076Z By default, use DLL dependencies for Chromium rather than for Google Chrome. (It's controlled by an environment variable.) BUG=1296800 TEST=covered by buildbots pamg@google.com 2008-08-30T21:11:45.550234Z Add version.dll as an expected dependency for chrome.exe again, now that breakpad is back in. BUG=none TEST=none (covered by buildbots) pamg@google.com 2008-08-31T14:36:12.966799Z Put version.dll back into chrome.exe's deps after not paying close enough attention to the format of the file. TBR=rahulk BUG=none TEST=covered by buildbots rahulk@google.com 2008-08-31T19:05:03.238519Z Some more changes so that Chromium and Google Chrome do not clash with each other while running at the same time. BUG=1296800